Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Character counts appear to have stopped working #70

Closed
2 tasks done
peteryates opened this issue Nov 22, 2019 · 0 comments
Closed
2 tasks done

Character counts appear to have stopped working #70

peteryates opened this issue Nov 22, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@peteryates
Copy link
Member

peteryates commented Nov 22, 2019 •
edited
Loading

It's not clear why this has happened but it looks like this is related - now the guidance text (eg. 'You can enter up to 300 characters') must be added initially rather than automatically by JavaScript

  • Add the description-generating functionality to the form builder e9fb5b6
  • Investigate why the JavaScript isn't updating the counter
@peteryates peteryates added the bug Something isn't working label Nov 22, 2019
peteryates added a commit that referenced this issue Jan 9, 2020
@peteryates
Add a manual link between text area and char count
b4ed58d 
The recent upgrade to the GOV.UK Design System 3.4.0 caused a bug where
the JavaScript character/word counters no longer worked. The Design
System now requires that the descriptive text is set manually[0], which
will improve the experience for users who have disabled JavaScript.

alphagov/govuk-frontend#1594

Fixes #70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peteryates