Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix bad alias usage in assets examples #1443

Merged
merged 1 commit into from
Feb 16, 2025
Merged

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Feb 16, 2025

Overview

Vite doesn't support aliases in HTML tags, like <img src="~/assets/example.png">, and our examples showed that it did.

I also added examples for Vue and JSX (react, solid, etc)

Related Issue

This PR closes #1440

Copy link

netlify bot commented Feb 16, 2025

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 577a01c
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/67b20ce8e8df4c000802387b
😎 Deploy Preview https://deploy-preview-1443--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aklinker1 aklinker1 marked this pull request as ready for review February 16, 2025 16:06
@aklinker1 aklinker1 requested a review from Timeraa as a code owner February 16, 2025 16:06
Copy link

pkg-pr-new bot commented Feb 16, 2025

Open in Stackblitz

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@1443

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@1443

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@1443

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@1443

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@1443

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@1443

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@1443

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@1443

wxt

npm i https://pkg.pr.new/wxt@1443

commit: 577a01c

Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.03%. Comparing base (44dab37) to head (577a01c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1443      +/-   ##
==========================================
- Coverage   81.19%   81.03%   -0.16%     
==========================================
  Files         128      128              
  Lines        6296     6296              
  Branches     1072     1069       -3     
==========================================
- Hits         5112     5102      -10     
- Misses       1169     1179      +10     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 merged commit 80ca576 into main Feb 16, 2025
20 checks passed
@aklinker1 aklinker1 deleted the fix-bad-assets-example branch February 16, 2025 16:12
Copy link

Thanks for helping make WXT better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundler path transform in HTML is not being applied
1 participant