Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect inlineConfig.mode when setting NODE_ENV #1416

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

aleclarson
Copy link
Contributor

Overview

I think this fix is self-explanatory, but let me know if you need clarification.

Manual Testing

  1. Add an expression that uses import.meta.env.DEV (or a statement wrapped with an if (import.meta.env.DEV) condition)

  2. Build with pnpm build --mode=development

  3. Notice how, without this PR, import.meta.env.DEV unexpectedly resolves to false.

Copy link

netlify bot commented Feb 11, 2025

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit b3bbdb6
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/67aae15be7495b0008728255
😎 Deploy Preview https://deploy-preview-1416--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Feb 12, 2025

Open in Stackblitz

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@1416

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@1416

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@1416

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@1416

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@1416

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@1416

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@1416

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@1416

wxt

npm i https://pkg.pr.new/wxt@1416

commit: b3bbdb6

@aklinker1 aklinker1 merged commit 655ba86 into wxt-dev:main Feb 12, 2025
16 checks passed
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.11%. Comparing base (0ff964a) to head (b3bbdb6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1416      +/-   ##
==========================================
- Coverage   81.25%   81.11%   -0.14%     
==========================================
  Files         128      128              
  Lines        6296     6297       +1     
  Branches     1070     1070              
==========================================
- Hits         5116     5108       -8     
- Misses       1165     1174       +9     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1
Copy link
Collaborator

Released in v0.19.27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants