Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup markdownlint and fix markdown formatting #1386

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

okineadev
Copy link
Contributor

Overview

  • Fixed Markdownlint violations, simplified formatting, minimized HTML usage, and improved readability

    Copilot summary

    This pull request includes several changes to improve the formatting and consistency of markdown files across the repository. The most important changes include updating email and URL formatting, modifying the README.md layout, and updating image links.

    Formatting improvements:

    Layout and link updates:

    • README.md: Modified the layout to use markdownlint rules, updated image links, and improved readability by using markdown syntax for links and images. [1] [2]
    • SECURITY.md: Updated image link formatting to use markdown syntax for consistency.

- Fixed Markdownlint violations, simplified formatting, minimized HTML usage, and improved readability
Copy link

netlify bot commented Feb 1, 2025

Deploy Preview for creative-fairy-df92c4 failed.

Name Link
🔨 Latest commit 50cc855
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/67b08e33f9558d0008a7f184

Copy link
Collaborator

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for wanting to fix lint errors, but we need to add the linter to the project, otherwise we're not going to follow the rules in any followup changes. So let's add markdownlint to the project and run it against all our files, and decide if it's something we want to follow or not.

At this point, I'm not convinced, seems like we're just adding a ton of ignore comments which is making things harder to read and maintain.

@okineadev
Copy link
Contributor Author

Thanks for wanting to fix lint errors, but we need to add the linter to the project, otherwise we're not going to follow the rules in any followup changes. So let's add markdownlint to the project and run it against all our files, and decide if it's something we want to follow or not.

At this point, I'm not convinced, seems like we're just adding a ton of ignore comments which is making things harder to read and maintain.

Yes, you're right, I thought about it too, but we need to make it so that HTML is allowed in the docs/ folder, and in all other documents, let there be a warning to minimize the use of HTML

@okineadev
Copy link
Contributor Author

I can do this tomorrow.

@okineadev okineadev changed the title docs: fix markdown formatting chore: setup markdownlint and fix markdown formatting Feb 3, 2025
Copy link
Collaborator

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for adding it! Couple of cleanup items, and we'll get this merged

docs/guide/essentials/config/runtime.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Collaborator

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are conflicts, once you fix them I'll get this merged!

@okineadev okineadev requested a review from aklinker1 February 13, 2025 11:01
@okineadev
Copy link
Contributor Author

lockfile broken

@aklinker1
Copy link
Collaborator

aklinker1 commented Feb 13, 2025

lockfile broken

Can you just run:

git checkout main pnpm-lock.yaml
pnpm i

That should reset it to what's on the main branch, then reapply the new packages you added in this PR.

@okineadev
Copy link
Contributor Author

lockfile broken

Can you just run:

git checkout main pnpm-lock.yaml
pnpm i

That should reset it to what's on the main branch, then reapply the new packages you added in this PR.

Probably fixed it

@aklinker1
Copy link
Collaborator

Hmm, I guess not. Now there's a problem with another dependency... I'll fix it and open another PR into your branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants