-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: setup markdownlint and fix markdown formatting #1386
base: main
Are you sure you want to change the base?
Conversation
- Fixed Markdownlint violations, simplified formatting, minimized HTML usage, and improved readability
❌ Deploy Preview for creative-fairy-df92c4 failed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for wanting to fix lint errors, but we need to add the linter to the project, otherwise we're not going to follow the rules in any followup changes. So let's add markdownlint
to the project and run it against all our files, and decide if it's something we want to follow or not.
At this point, I'm not convinced, seems like we're just adding a ton of ignore comments which is making things harder to read and maintain.
Yes, you're right, I thought about it too, but we need to make it so that HTML is allowed in the |
I can do this tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for adding it! Couple of cleanup items, and we'll get this merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are conflicts, once you fix them I'll get this merged!
lockfile broken |
Can you just run: git checkout main pnpm-lock.yaml
pnpm i That should reset it to what's on the |
567fdc0
to
cd9361c
Compare
Probably fixed it |
Hmm, I guess not. Now there's a problem with another dependency... I'll fix it and open another PR into your branch |
Overview
Fixed Markdownlint violations, simplified formatting, minimized HTML usage, and improved readability
Copilot summary
This pull request includes several changes to improve the formatting and consistency of markdown files across the repository. The most important changes include updating email and URL formatting, modifying the
README.md
layout, and updating image links.Formatting improvements:
CODE_OF_CONDUCT.md
: Updated email and URL formatting to use angle brackets for consistency. [1] [2]CONTRIBUTING.md
: Updated URL formatting to use angle brackets for consistency.Layout and link updates:
README.md
: Modified the layout to use markdownlint rules, updated image links, and improved readability by using markdown syntax for links and images. [1] [2]SECURITY.md
: Updated image link formatting to use markdown syntax for consistency.