ci: Add PR title checker workflow and thank-you comment on merge #1385
+135
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated the section on Conventional Pull Request Titles in `CONTRIBUTING.md` * Added GitHub Actions workflows to check PR titles and post a thank-you comment upon merging * Introduced `commitlint` configuration to enforce title conventions for pull requests
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aklinker1
requested changes
Feb 8, 2025
There was a problem hiding this comment.
Sweet, this will be nice to have. It's quite annoying for maintainers to edit PR titles. But realistically, we'll still need to rename PRs to better represent what's actually being changed and match changelog tone. It's hard for people to come up with a good name without the full context of the project.
Co-authored-by: Aaron <aaronklinker1@gmail.com>
Co-authored-by: Aaron <aaronklinker1@gmail.com>
Co-authored-by: Aaron <aaronklinker1@gmail.com>
aklinker1
requested changes
Feb 15, 2025
Co-authored-by: Aaron <aaronklinker1@gmail.com>
aklinker1
reviewed
Feb 15, 2025
@wxt-dev/auto-icons
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/storage
wxt
@wxt-dev/unocss
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1385 +/- ##
==========================================
- Coverage 81.36% 81.22% -0.15%
==========================================
Files 128 128
Lines 6296 6296
Branches 1074 1070 -4
==========================================
- Hits 5123 5114 -9
- Misses 1158 1167 +9
Partials 15 15 ☔ View full report in Codecov by Sentry. |
|
And formatting is failing. Run |
Co-authored-by: Aaron <aaronklinker1@gmail.com>
Done |
aklinker1
approved these changes
Feb 16, 2025
|
Thanks for helping make WXT better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
CONTRIBUTING.mdcommitlintconfiguration to enforce title conventions for pull requestsFor now, this is to test the functionality of the checks
Manual Testing
I believe it works