Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Add suffix to non-production output directories #1086

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Oct 19, 2024

This is not being merged into main, but the v0.20.0 staging branch.


BREAKING CHANGE: The build mode is now apart of the output directory:

  • --mode production.output/chrome-mv3 (unchanged)
  • --mode development.output/chrome-mv3-dev (dev builds are output with the "-dev" suffix)
  • --mode other.output/chrome-mv3-other (all other build modes are output with the "-[mode]" suffix)

To revert back to the old behavior and output all builds to the same directory, set the outDirTemplate option:

// wxt.config.ts
export default defineConfig({
+ outDirTemplate: "{{browser}}-mv{{manifestVersion}}",
});

⚠️ If you use --user-data-dir in your runner config, be aware that web-ext is a little buggy when you change the output directory of an extension. If you notice that your code isn't reloading properly after saving a file, uninstall the extension by hand and rerun the dev command.

@aklinker1 aklinker1 force-pushed the 0.20.0-breaking-changes branch from 8336c41 to 14ea7cc Compare October 19, 2024 10:07
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.83%. Comparing base (14ea7cc) to head (007d61a).
Report is 1 commits behind head on 0.20.0-breaking-changes.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           0.20.0-breaking-changes    #1086      +/-   ##
===========================================================
+ Coverage                    81.69%   81.83%   +0.14%     
===========================================================
  Files                          125      125              
  Lines                         6625     6627       +2     
  Branches                      1104     1107       +3     
===========================================================
+ Hits                          5412     5423      +11     
+ Misses                        1196     1187       -9     
  Partials                        17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 marked this pull request as ready for review October 19, 2024 10:15
@aklinker1 aklinker1 changed the title fix!: Add suffix to non-production build output directories fix!: Add suffix to non-production output directories Oct 19, 2024
@aklinker1 aklinker1 merged commit 7c51e0a into 0.20.0-breaking-changes Oct 19, 2024
12 checks passed
@aklinker1 aklinker1 deleted the add-mode-suffix branch October 19, 2024 10:23
@aklinker1 aklinker1 mentioned this pull request Oct 19, 2024
21 tasks
@aklinker1 aklinker1 added this to the v1.0 milestone Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant