Suggested changes for #1370

wxt-dev · Feb 13, 2025 · b06b56a · b06b56a
1 parent 76e362f
commit b06b56a
Show file tree

Hide file tree

Showing 6 changed files with 100 additions and 46 deletions.
diff --git a/.github/workflows/pkg.pr.new.yml b/.github/workflows/pkg.pr.new.yml
@@ -3,23 +3,25 @@ on:
   push:
     branches:
       - main
-
   pull_request:
     branches:
       - main
 
+permissions:
+  contents: read
+
 jobs:
   build:
+    name: Build
     runs-on: ubuntu-22.04
-
     steps:
       - name: Checkout
         uses: actions/checkout@v4
 
       - name: Setup
         uses: ./.github/actions/setup
 
-      - name: Build
+      - name: Build All Packages
         run: pnpm buildc all
 
       - name: Publish

diff --git a/.github/workflows/publish-docs.yml b/.github/workflows/publish-docs.yml
@@ -1,24 +1,26 @@
 name: 📝 Publish Docs
-
 on:
   push:
     branches:
       - main
-
   workflow_dispatch:
     inputs:
       tag:
         description: Docker Image Tag
         required: true
         default: latest
 
+permissions:
+  contents: read
+
 jobs:
   publish:
     # Only run if it's the upstream repository, not forks
     if: github.repository == 'wxt-dev/wxt'
-
+    name: Publish Docs
     runs-on: ubuntu-22.04
-
+    permissions:
+      contents: write
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -38,5 +40,8 @@ jobs:
           pnpm docs:build
           docker build docs/.vitepress -t ${{ secrets.DOCKER_REGISTRY_HOSTNAME }}/wxt/docs:${{ github.event.inputs.tag || 'latest' }}
 
-      - run: docker push ${{ secrets.DOCKER_REGISTRY_HOSTNAME }}/wxt/docs:${{ github.event.inputs.tag || 'latest' }}
-      - run: curl -X POST -i ${{ secrets.UPDATE_DOCS_WEBHOOK }}
+      - name: Push Image
+        run: docker push ${{ secrets.DOCKER_REGISTRY_HOSTNAME }}/wxt/docs:${{ github.event.inputs.tag || 'latest' }}
+
+      - name: Deploy
+        run: curl -X POST -i ${{ secrets.UPDATE_DOCS_WEBHOOK }}
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -1,5 +1,4 @@
 name: 🚀 Release
-
 on:
   workflow_dispatch:
     inputs:
@@ -18,17 +17,22 @@ on:
           - unocss
           - wxt
 
+permissions:
+  contents: read
+
 jobs:
   validate:
+    name: Validate
     uses: './.github/workflows/validate.yml'
     secrets: inherit
 
   publish:
+    name: Publish
     runs-on: ubuntu-22.04
-
+    permissions:
+      contents: write
     needs:
       - validate
-
     steps:
       - name: Checkout
         uses: actions/checkout@v4

diff --git a/.github/workflows/sync-releases.yml b/.github/workflows/sync-releases.yml
@@ -16,10 +16,15 @@ on:
           - storage
           - wxt
 
+permissions:
+  contents: read
+
 jobs:
   sync:
+    name: Sync Releases
     runs-on: ubuntu-22.04
-
+    permissions:
+      contents: write
     steps:
       - name: Checkout
         uses: actions/checkout@v4

diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml
@@ -1,5 +1,4 @@
 name: ✅ Validate
-
 on:
   workflow_call:
   pull_request:
@@ -15,49 +14,79 @@ jobs:
     name: Checks
     runs-on: ubuntu-22.04
     steps:
-      - uses: actions/checkout@v4
-      - uses: ./.github/actions/setup
-      - run: pnpm check
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup
+        uses: ./.github/actions/setup
+
+      - name: Type Check
+        run: pnpm check
 
   builds:
     name: Builds
     runs-on: ubuntu-22.04
     steps:
-      - uses: actions/checkout@v4
-      - uses: ./.github/actions/setup
-      - run: pnpm buildc all
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup
+        uses: ./.github/actions/setup
+
+      - name: Build All Packages
+        run: pnpm buildc all
 
   build-demo:
     name: Build Demo
     runs-on: ubuntu-22.04
     steps:
-      - uses: actions/checkout@v4
-      - uses: ./.github/actions/setup
-      - run: pnpm build:all
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup
+        uses: ./.github/actions/setup
+
+      - name: Build
+        run: pnpm build:all
         working-directory: packages/wxt-demo
-      - run: pnpm wxt zip
+
+      - name: ZIP
+        run: pnpm wxt zip
         working-directory: packages/wxt-demo
 
   tests:
     name: Tests
     runs-on: ubuntu-22.04
     steps:
-      - uses: actions/checkout@v4
-      - uses: ./.github/actions/setup
-      - uses: oven-sh/setup-bun@v2
-      - name: pnpm test:coverage
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup
+        uses: ./.github/actions/setup
+
+      - name: Setup Bun
+        uses: oven-sh/setup-bun@v2
+
+      - name: Run Tests
         run: pnpm test:coverage -- --reporter=default --reporter=hanging-process
-      - uses: codecov/codecov-action@v5
+
+      - name: Upload Coverage
+        uses: codecov/codecov-action@v5
         env:
           CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
 
   windows-tests:
     name: Windows Tests
     runs-on: windows-latest
     steps:
-      - uses: actions/checkout@v4
-      - uses: ./.github/actions/setup
-      - run: pnpm test
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup
+        uses: ./.github/actions/setup
+
+      - name: Run Tests
+        run: pnpm test
 
   template:
     name: Template
@@ -71,27 +100,35 @@ jobs:
           - svelte
           - vanilla
           - vue
-
     steps:
-      - uses: actions/checkout@v4
-      - uses: ./.github/actions/setup
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup
+        uses: ./.github/actions/setup
 
-      - run: pnpm pack
+      - name: Pack WXT package
+        run: pnpm pack
         working-directory: packages/wxt
 
-      - run: npm i
+      - name: Install Dependencies
+        run: npm i
         working-directory: templates/${{ matrix.template }}
 
-      - run: npm i -D ../../packages/wxt/wxt-*.tgz
+      - name: Install Packed WXT
+        run: npm i -D ../../packages/wxt/wxt-*.tgz
         working-directory: templates/${{ matrix.template }}
 
-      - run: pnpm compile
+      - name: Type Check Template
+        run: pnpm compile
         if: matrix.template != 'svelte'
         working-directory: templates/${{ matrix.template }}
 
-      - run: pnpm check
+      - name: Type Check Template
+        run: pnpm check
         if: matrix.template == 'svelte'
         working-directory: templates/${{ matrix.template }}
 
-      - run: pnpm build
+      - name: Build Template
+        run: pnpm build
         working-directory: templates/${{ matrix.template }}
diff --git a/.github/workflows/vhs.yml b/.github/workflows/vhs.yml
@@ -1,19 +1,19 @@
 name: 📼 VHS
-
 on:
   push:
     paths:
       - 'docs/tapes/*.tape'
-
   workflow_dispatch:
 
 permissions:
-  contents: write
+  contents: read
 
 jobs:
   vhs:
+    name: Create VHS
     runs-on: ubuntu-22.04
-
+    permissions:
+      contents: write
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -23,7 +23,8 @@ jobs:
         with:
           install: false
 
-      - name: Install WXT
+      # This prevents pnpm dlx from downloading WXT in the video
+      - name: Pre-install WXT
         run: |
           pnpm store add wxt@latest
           pnpm dlx wxt@latest --version