Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The docs were using thenPresent but they should be using thenProceed #185

Merged
merged 2 commits into from
Mar 3, 2022

Conversation

nickkaczmarek
Copy link
Contributor

Linked Issue: #184

Checklist:

@nickkaczmarek nickkaczmarek added the documentation Improvements or additions to documentation label Mar 3, 2022
@nickkaczmarek nickkaczmarek requested a review from a team as a code owner March 3, 2022 15:09
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #185 (3a8c41e) into main (edaedd0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files          92       92           
  Lines        2375     2375           
=======================================
  Hits         2168     2168           
  Misses        207      207           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 510783c...3a8c41e. Read the comment docs.

morganzellers
morganzellers previously approved these changes Mar 3, 2022
@nickkaczmarek
Copy link
Contributor Author

@morganzellers I was talking to @Tyler-Keith-Thompson about this before I merged and he mentioned that the api is actually thenProceed(with:) so I updated the examples.

@morganzellers
Copy link
Contributor

@nickkaczmarek ah yes. My bad on that miss - I knew waiting to merge was a good choice.

@morganzellers morganzellers merged commit 56cf9c7 into main Mar 3, 2022
@morganzellers morganzellers deleted the updating-docs-to-not-use-deprecated-apis branch March 3, 2022 18:55
@nickkaczmarek nickkaczmarek linked an issue Mar 4, 2022 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Documentation is showing deprecated versions of the api
3 participants