Replaces `WorkflowLauncher` and `thenProceed(with:)` with a new `WorkflowView` API, as discussed in #61 #179

Tyler-Keith-Thompson · 2022-02-21T17:24:26Z

Linked Issue: Closes #156

Checklist:

If Applicable:

Did you test when the first item is skipped?
Did you test when the last item is skipped?
Did you test when middle items are skipped?
Did you test when incorrect data is passed forward?
Did you test proceeding backwards?

If Public API Has Changed:

Did you deprecate (rather than remove) any old methods/variables/etc? Our philosophy for deprecation.
Have you done the best that you can to make sure that the compiler guides people to changing to the new API? (Example: the renamed attribute)
If necessary, have you tested the upgrade path for at least N-1 versions? For example, if data persists between v1 and v2 then that upgrade should be tested and as easy as we can make it.

Co-authored-by: Matt Freiburg <Matt.Freiburg@wwt.com>

…7 items supported - TT

…ther API is your best bet - TT

…iftLint happy - TT

…- mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

…owView - mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

… mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

…h WorkflowView - mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

…WorkflowView - mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

… mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

… WofkflowView - mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

…orklowView - mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

…able in WorkflowView - mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

…t type for first item in WorkflowView - mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

…able in the middle for WorkflowView - mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

…rkflowView - mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

…kflowView - mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

…specialize WorkflowItem - mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

…ions to specialize WorkflowItem - mf tt nk" This reverts commit 9ac8d76.

… too - TT MF NK Co-authored-by: Matt Freiburg <Matt.Freiburg@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

codecov-commenter · 2022-02-21T22:16:00Z

Codecov Report

Merging #179 (94f06fe) into main (f69e8ac) will decrease coverage by 0.30%.
The diff coverage is 87.76%.

@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
- Coverage   91.28%   90.97%   -0.31%     
==========================================
  Files          92      102      +10     
  Lines        2375     2538     +163     
==========================================
+ Hits         2168     2309     +141     
- Misses        207      229      +22

Impacted Files	Coverage Δ
...xample/Views/Settings/SettingsViewController.swift	`0.00% <0.00%> (ø)`
...UI/Deprecations/WorkflowLauncherDeprecations.swift	`0.00% <0.00%> (ø)`
...rent_SwiftUI/ViewModifiers/NavigationWrapper.swift	`100.00% <ø> (ø)`
...rent_SwiftUI/Protocols/_WorkflowItemProtocol.swift	`25.00% <25.00%> (ø)`
...Example/Views/Profile/AccountInformationView.swift	`79.71% <41.17%> (ø)`
...ftUIExample/SwiftUIExample/SwiftUIExampleApp.swift	`92.30% <80.00%> (ø)`
...ws/Settings/SettingsOnboardingViewController.swift	`88.23% <88.23%> (ø)`
ExampleApps/SwiftUIExample/Views/ContentView.swift	`93.75% <100.00%> (+1.44%)`	⬆️
ExampleApps/SwiftUIExample/Views/LoginView.swift	`94.33% <100.00%> (ø)`
...rrent_SwiftUI/ResultBuilders/WorkflowBuilder.swift	`100.00% <100.00%> (ø)`
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ad629b...94f06fe. Read the comment docs.

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

Co-authored-by: Matt Freiburg <Matt.Freiburg@wwt.com>

…o v5 changes - TT

…uncher. - nk tt Co-authored-by: Tyler Thompson <tyler.thompson@wwt.com>

nickkaczmarek

Left some comments about casing in the docs.

.github/abstract/Creating Workflows in SwiftUI.md

.github/abstract/Creating Workflows.md

.github/guides/Getting Started with SwiftUI.md

Co-authored-by: Nick Kaczmarek <nick.kaczmarek@wwt.com>

…orkflow-builder

…s docs - TT

… to ensure we have compiled code for this feature. - nk

nickkaczmarek

Added some UIKit interop code to ensure that we are definitely testing all the bits. I think we're ready to release!

.github/guides/Getting Started with SwiftUI.md

Sources/SwiftCurrent_SwiftUI/Views/WorkflowItem.swift

Tyler-Keith-Thompson and others added 23 commits February 21, 2022 10:22

[workflow-builder] - A very basic version of the API works! - TT MF

896cf26

Co-authored-by: Matt Freiburg <Matt.Freiburg@wwt.com>

[workflow-builder] - We managed to dedup the code! - TT MF

bf44f41

Co-authored-by: Matt Freiburg <Matt.Freiburg@wwt.com>

[workflow-builder] - Next set of tests completed and workflows up to …

bab2071

…7 items supported - TT

[workflow-builder] - 10 item workflows now supported, past that the o…

742a4d7

…ther API is your best bet - TT

[workflow-builder] - Better formatting around these huge generics - TT

ffec112

[workflow-builder] - Some additional tests and some things to make Sw…

c9d52f5

…iftLint happy - TT

[workflow-builder] - Adding support for startingArgs on WorkflowView …

1aa38c9

…- mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

[workflow-builder] - Adding Anyworkflow.PassedArgs support for Workfl…

86b1ed7

…owView - mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

[workflow-builder] - Additional overload for Anyworkflow.PassedArgs -…

8e5a11b

… mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

[workflow-builder] - Testing that multiple different arguments throug…

f6dcff0

…h WorkflowView - mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

[workflow-builder] - Fixing some linting errors - mf tt nk

929491d

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

[workflow-builder] - Adding onAbandon support, isLaunched Binding to …

9e41a8b

…WorkflowView - mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

[workflow-builder] - Supporting multiple onAbandons to WorkflowView -…

f66a216

… mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

[workflow-builder] - Ensuring applyModifiers works on WorkflowItem in…

4caf9a4

… WofkflowView - mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

[workflow-builder] - Ensuring Workflow relaunches when abandoned in W…

b8cc780

…orklowView - mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

[workflow-builder] - Ensuring Workflow can hav a passthroughRepresent…

a190d1d

…able in WorkflowView - mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

[workflow-builder] - Ensuring workflow can convert any args to correc…

a45630f

…t type for first item in WorkflowView - mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

[workflow-builder] - Ensuring Workflow can hav a passthroughRepresent…

3f9b0e3

…able in the middle for WorkflowView - mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

[workflow-builder] - Ensure workflow correctly handles state using Wo…

6da6686

…rkflowView - mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

[workflow-builder] - Ensure workflow can have a delayed launch in Wor…

432cced

…kflowView - mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

[workflow-builder] - Doing weird backflips to make github actions to …

9ac8d76

…specialize WorkflowItem - mf tt nk Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

Revert "[workflow-builder] - Doing weird backflips to make github act…

4ca0478

…ions to specialize WorkflowItem - mf tt nk" This reverts commit 9ac8d76.

[workflow-builder] - Made WorkflowView inspectable in SwiftUIExample,…

c86d135

… too - TT MF NK Co-authored-by: Matt Freiburg <Matt.Freiburg@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

MattFreiburgAsynchrony and others added 6 commits February 21, 2022 16:23

[workflow-builder] - Adding Arity tests - mf tt nk

2fae4dd

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

[workflow-builder] - Adding documentation for WorkflowView - mf tt nk

32d70ab

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

[skip ci] workflow-builder - EmbedInNavigationView - mf tt nk

182ce1d

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com> Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>

[workflow-builder] - Added embedInNavigationView to WorkflowView - TT MF

3ae49cf

Co-authored-by: Matt Freiburg <Matt.Freiburg@wwt.com>

[workflow-builder] - DEAD CODE REMOVAL, - TT MF

0cb07c6

Co-authored-by: Matt Freiburg <Matt.Freiburg@wwt.com>

[workflow-builder] - Added docs to WorkflowBuilder - TT MF

baf3f4f

Co-authored-by: Matt Freiburg <Matt.Freiburg@wwt.com>

Tyler-Keith-Thompson and others added 3 commits March 18, 2022 09:29

Merge branch 'main' into workflow-builder

45b68da

[workflow-builder] - Fixed some comments as per PR suggestion - TT

d4427f4

[workflow-builder] - Upgrade path has been updated to talk about v4 t…

1299cd7

…o v5 changes - TT

morganzellers previously approved these changes Mar 18, 2022

View reviewed changes

[workflow-builder] - Adds deprecations for thenProceed and WorkflowLa…

48379c4

…uncher. - nk tt Co-authored-by: Tyler Thompson <tyler.thompson@wwt.com>

nickkaczmarek dismissed morganzellers’s stale review via 48379c4 March 18, 2022 17:47

nickkaczmarek suggested changes Mar 18, 2022

View reviewed changes

.github/abstract/Creating Workflows in SwiftUI.md Outdated Show resolved Hide resolved

.github/abstract/Creating Workflows.md Outdated Show resolved Hide resolved

.github/guides/Getting Started with SwiftUI.md Show resolved Hide resolved

Tyler-Keith-Thompson and others added 2 commits March 18, 2022 11:49

Update .github/abstract/Creating Workflows in SwiftUI.md

ca4ece5

Co-authored-by: Nick Kaczmarek <nick.kaczmarek@wwt.com>

Update .github/abstract/Creating Workflows.md

c078f37

Co-authored-by: Nick Kaczmarek <nick.kaczmarek@wwt.com>

Tyler-Keith-Thompson requested review from nickkaczmarek and morganzellers March 18, 2022 18:10

Tyler-Keith-Thompson added 3 commits March 18, 2022 12:20

[workflow-builder] - Fixed some docs on WorkflowItem - TT

7118850

Merge branch 'workflow-builder' of github.com:wwt/SwiftCurrent into w…

1ff53bc

…orkflow-builder

[workflow-builder] - WorkflowBuilder needed a bit more context for it…

c8d04ad

…s docs - TT

morganzellers previously approved these changes Mar 18, 2022

View reviewed changes

[workflow-builder] - Added UIKit interop into the SwiftUI example app…

5604437

… to ensure we have compiled code for this feature. - nk

nickkaczmarek dismissed morganzellers’s stale review via 5604437 March 18, 2022 21:27

nickkaczmarek previously approved these changes Mar 18, 2022

View reviewed changes

.github/guides/Getting Started with SwiftUI.md Outdated Show resolved Hide resolved

Sources/SwiftCurrent_SwiftUI/Views/WorkflowItem.swift Outdated Show resolved Hide resolved

Update .github/guides/Getting Started with SwiftUI.md

8f91a0b

nickkaczmarek dismissed stale reviews from themself via 8f91a0b March 18, 2022 21:28

nickkaczmarek previously approved these changes Mar 18, 2022

View reviewed changes

[workflow-builder] - Fix linter error - TT

94f06fe

Tyler-Keith-Thompson dismissed nickkaczmarek’s stale review via 94f06fe March 18, 2022 21:42

Tyler-Keith-Thompson changed the title ~~Replaces WorkflowLauncher and thenProceed(with:) with a new WorkflowView API, as discussed in #61~~ DO NOT MERGE Replaces WorkflowLauncher and thenProceed(with:) with a new WorkflowView API, as discussed in #61 Mar 21, 2022

Tyler-Keith-Thompson changed the title ~~DO NOT MERGE Replaces WorkflowLauncher and thenProceed(with:) with a new WorkflowView API, as discussed in #61~~ Replaces WorkflowLauncher and thenProceed(with:) with a new WorkflowView API, as discussed in #61 Mar 21, 2022

nickkaczmarek approved these changes Mar 21, 2022

View reviewed changes

morganzellers approved these changes Mar 21, 2022

View reviewed changes

nickkaczmarek merged commit 40432d4 into main Mar 21, 2022

nickkaczmarek deleted the workflow-builder branch March 21, 2022 15:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replaces `WorkflowLauncher` and `thenProceed(with:)` with a new `WorkflowView` API, as discussed in #61 #179

Replaces `WorkflowLauncher` and `thenProceed(with:)` with a new `WorkflowView` API, as discussed in #61 #179

Tyler-Keith-Thompson commented Feb 21, 2022 •

edited

Loading

codecov-commenter commented Feb 21, 2022 •

edited

Loading

nickkaczmarek left a comment

nickkaczmarek left a comment

Replaces WorkflowLauncher and thenProceed(with:) with a new WorkflowView API, as discussed in #61 #179

Replaces WorkflowLauncher and thenProceed(with:) with a new WorkflowView API, as discussed in #61 #179

Conversation

Tyler-Keith-Thompson commented Feb 21, 2022 • edited Loading

Linked Issue: Closes #156

Checklist:

If Applicable:

If Public API Has Changed:

codecov-commenter commented Feb 21, 2022 • edited Loading

Codecov Report

nickkaczmarek left a comment

Choose a reason for hiding this comment

nickkaczmarek left a comment

Choose a reason for hiding this comment

Replaces `WorkflowLauncher` and `thenProceed(with:)` with a new `WorkflowView` API, as discussed in #61 #179

Replaces `WorkflowLauncher` and `thenProceed(with:)` with a new `WorkflowView` API, as discussed in #61 #179

Tyler-Keith-Thompson commented Feb 21, 2022 •

edited

Loading

codecov-commenter commented Feb 21, 2022 •

edited

Loading