Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal (fix): Collect coverage report xml files properly #3138

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

xerial
Copy link
Member

@xerial xerial commented Aug 12, 2023

Due to the change in #3137, coverageAggregate now runs on Scala 3 and chooses a different test report folder. This PR removes scala-2.xx or scala-3 version name from the test report path.

@github-actions github-actions bot added bug internal Internal changes (usually non-user facing) labels Aug 12, 2023
@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Merging #3138 (b95d77e) into main (9527b32) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3138   +/-   ##
=======================================
  Coverage   82.88%   82.89%           
=======================================
  Files         350      350           
  Lines       14737    14737           
  Branches     2440     2440           
=======================================
+ Hits        12215    12216    +1     
+ Misses       2522     2521    -1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cdd145...b95d77e. Read the comment docs.

@xerial xerial enabled auto-merge (squash) August 12, 2023 08:28
@xerial xerial merged commit 5dc3ec1 into main Aug 12, 2023
@xerial xerial deleted the codecov-scala-3 branch August 12, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug internal Internal changes (usually non-user facing)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant