Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http (internal): Rename BuildInfo to AirframeBuildInfo #3136

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

xerial
Copy link
Member

@xerial xerial commented Aug 12, 2023

Fixes #3133

@github-actions github-actions bot added the internal Internal changes (usually non-user facing) label Aug 12, 2023
@xerial xerial enabled auto-merge (squash) August 12, 2023 06:44
@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Merging #3136 (b642aac) into main (24304d0) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3136      +/-   ##
==========================================
- Coverage   82.88%   82.87%   -0.02%     
==========================================
  Files         350      350              
  Lines       14736    14737       +1     
  Branches     2440     2440              
==========================================
- Hits        12214    12213       -1     
- Misses       2522     2524       +2     
Files Changed Coverage Δ
...let/airframe/http/grpc/GrpcClientInterceptor.scala 100.00% <100.00%> (ø)
...irframe/http/grpc/internal/GrpcRequestLogger.scala 87.09% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24304d0...b642aac. Read the comment docs.

@xerial xerial merged commit 9527b32 into main Aug 12, 2023
@xerial xerial deleted the build-info-rename branch August 12, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal changes (usually non-user facing)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename BuildInfo to AirframeBuildInfo to avoid confusion
1 participant