NEX-25: Update to next-drupal 1.6.0, next 1.6.0 and next.js 13 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vermario
commented
Dec 9, 2022
| }, | ||
| webpackFinal: async (config) => { | ||
| config.resolve.plugins = [ |
There was a problem hiding this comment.
This config and the next are taken from https://theodorusclarence.com/blog/nextjs-storybook-tailwind
vermario
commented
Dec 9, 2022
| builder: "@storybook/builder-webpack5", | ||
| }, | ||
| webpackFinal: async (config) => { |
There was a problem hiding this comment.
This one will make storybook recognize paths like "components/somecomponent", taken from storybookjs/storybook#14087 (comment)
vermario
commented
Dec 9, 2022
| @@ -1,3 +1,5 @@ | |||
| import "../styles/globals.css"; | |||
There was a problem hiding this comment.
this way the components will display the right styles in storybook:
vermario
commented
Dec 9, 2022
| @@ -6,3 +6,5 @@ label: 'Next.js frontend' | |||
| base_url: 'http://localhost:3000' | |||
| preview_url: 'http://localhost:3000/api/preview' | |||
| preview_secret: null | |||
| revalidate_url: 'http://localhost:3000/api/revalidate' | |||
There was a problem hiding this comment.
This configuration is for now empty, I have made a new story to actually activate this functionality: https://wunder.atlassian.net/browse/NEX-26
juhov
reviewed
Dec 9, 2022
| */ | ||
| config.resolve.roots = [ | ||
| path.resolve(__dirname, "../public"), |
There was a problem hiding this comment.
FYI: No need to change anything, but Storybook has staticDirs config that could be used for this too.
juhov
approved these changes
Dec 9, 2022
jekku123
pushed a commit
that referenced
this pull request
Oct 20, 2024
NEX-25: Update to next-drupal 1.6.0, next 1.6.0 and next.js 13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://wunder.atlassian.net/browse/NEX-25
Changes proposed in this PR:
How to test: