Fixed JWT signature calculation (1.8.x release) #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrdvorak
approved these changes
Sep 10, 2024
| @@ -2530,22 +2545,16 @@ public void onBiometricDialogFailed(@NonNull PowerAuthErrorException error) { | |||
| @Nullable | |||
| public ICancelable signJwtWithDevicePrivateKey(@NonNull Context context, @NonNull PowerAuthAuthentication authentication, @NonNull Map<String, Object> claims, @NonNull IJwtSignatureListener listener) { | |||
| final JsonSerialization serialization = new JsonSerialization(); | |||
| final byte[] serializedClaims = serialization.serializeObject(claims); | |||
| return signDataWithDevicePrivateKey(context, authentication, serializedClaims, new IDataSignatureListener() { | |||
| final String jwtHeader = "eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCJ9"; // {"alg":"ES256","typ":"JWT"} | |||
There was a problem hiding this comment.
This feels a bit arbitrary, could we extract it to some constant, i.e., JwtHeader.ES256?
There was a problem hiding this comment.
Java / Objective-C is already ugly enough language, so adding 4-5 more lines just to be "nice" makes no sense to me :)
There was a problem hiding this comment.
Well, we intend to publish it to the world, I will leave it up to you - review is approved.
| - (id<PowerAuthOperationTask>) signJwtWithDevicePrivateKey:(PowerAuthAuthentication*)authentication | ||
| claims:(NSDictionary<NSString*, NSObject*>*)claims | ||
| callback:(void(^)(NSString *jwt, NSError *error))callback | ||
| { | ||
| // Prepare JWT Header | ||
| NSString * jwtHeader = @"eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCJ9."; // {"alg":"ES256","typ":"JWT"} |
There was a problem hiding this comment.
dtto, extraction to some constant would probably be helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes JWT signature calculation for 1.8.x release branch