-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #913: Improve error handling in MobileTokenController #992
Conversation
...rver/src/main/java/com/wultra/app/enrollmentserver/controller/api/MobileTokenController.java
Outdated
Show resolved
Hide resolved
...rver/src/main/java/com/wultra/app/enrollmentserver/controller/api/MobileTokenController.java
Outdated
Show resolved
Hide resolved
...odel/src/main/java/com/wultra/security/powerauth/lib/mtoken/model/enumeration/ErrorCode.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have nothing to add, however I agree with @banterCZ comments, especially reusing the RemoteCommunicationException
for consistency with other endpoints. It would be probably confusing to introduce a new exception class for the same purpose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok from BE point of view. Let's wait for approval from mobile developers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Fix #913
by resolving the error code in the exception.