Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #913: Improve error handling in MobileTokenController #992

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

jnpsk
Copy link
Contributor

@jnpsk jnpsk commented Jan 12, 2024

Fix #913
by resolving the error code in the exception.

@jnpsk jnpsk requested a review from banterCZ January 12, 2024 14:39
@banterCZ banterCZ requested a review from romanstrobl January 12, 2024 15:43
Copy link
Member

@romanstrobl romanstrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have nothing to add, however I agree with @banterCZ comments, especially reusing the RemoteCommunicationException for consistency with other endpoints. It would be probably confusing to introduce a new exception class for the same purpose.

@jnpsk jnpsk requested a review from banterCZ January 16, 2024 14:30
Copy link
Member

@banterCZ banterCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok from BE point of view. Let's wait for approval from mobile developers.

@jnpsk jnpsk requested a review from kober32 February 2, 2024 09:26
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jnpsk jnpsk merged commit 7af9241 into develop Feb 20, 2024
4 checks passed
@jnpsk jnpsk deleted the issues/913-error-handling branch February 20, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error handling in MobileTokenController
4 participants