Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #478: InvalidRequestObjectException handler #479

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

banterCZ
Copy link
Member

No description provided.

@banterCZ banterCZ requested a review from romanstrobl October 24, 2022 07:26
@@ -63,8 +63,8 @@ public class DefaultExceptionHandler {
@ExceptionHandler(InvalidRequestObjectException.class)
@ResponseStatus(HttpStatus.BAD_REQUEST)
public @ResponseBody ErrorResponse handleInvalidRequestException(InvalidRequestObjectException ex) {
logger.warn("Error occurred when registering to push server.", ex);
return new ErrorResponse("INVALID_REQUEST", "Invalid request object sent to Mobile Token API component.");
logger.warn("Error occurred when processing request object.", ex);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Texting is confusing. The exception is related not only to push server or mtoken. It is thrown in ActivationCodeService, PushRegistrationService and OnboardingServiceImpl.

Copy link
Member

@romanstrobl romanstrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@banterCZ banterCZ merged commit f297897 into develop Oct 24, 2022
@banterCZ banterCZ deleted the issues/478-InvalidRequestObjectException-handler branch October 24, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants