Fix #389: SCA passes even though iProov failed #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banterCZ
commented
Sep 26, 2022
| */ | ||
| @PostMapping("presence-check/submit") | ||
| @PowerAuthEncryption(scope = EciesScope.ACTIVATION_SCOPE) | ||
| @PowerAuth(resourceId = "/api/identity/presence-check/submit", signatureType = PowerAuthSignatureTypes.POSSESSION) |
There was a problem hiding this comment.
@kober32 A new endpoint.
| @@ -182,13 +180,12 @@ private OtpVerifyResponse verifyPresenceCheck(final OnboardingProcessEntity proc | |||
| final String rejectReason = idVerification.getRejectReason(); | |||
| final RejectOrigin rejectOrigin = idVerification.getRejectOrigin(); | |||
|
|
|||
| if (errorOrigin == ErrorOrigin.PRESENCE_CHECK && StringUtils.isNotBlank(errorDetail) | |||
| || rejectOrigin == RejectOrigin.PRESENCE_CHECK && StringUtils.isNotBlank(rejectReason)) { | |||
| if (errorOrigin == ErrorOrigin.PRESENCE_CHECK || rejectOrigin == RejectOrigin.PRESENCE_CHECK) { | |||
There was a problem hiding this comment.
Not sure whether this is a permanent or temporary change. When we called iProov validate before verification, the reject reason was null so SCA passed.
|
|
||
| .and() | ||
| .withExternal() | ||
| .source(OnboardingState.PRESENCE_CHECK_VERIFICATION_PENDING) |
There was a problem hiding this comment.
@kober32 You may expect PRESENCE_CHECK / VERIFICATION_PENDING at the status endpoint.
saalistaja
reviewed
Sep 26, 2022
...ngserver/statemachine/action/presencecheck/MoveToPresenceCheckVerificationPendingAction.java
Outdated
Show resolved
Hide resolved
saalistaja
reviewed
Sep 26, 2022
banterCZ
commented
Sep 26, 2022
...main/java/com/wultra/app/onboardingserver/controller/api/IdentityVerificationController.java
Outdated
Show resolved
Hide resolved
banterCZ
commented
Sep 26, 2022
...main/java/com/wultra/app/onboardingserver/controller/api/IdentityVerificationController.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.