Fix #365: Unable to retry presence check init #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
banterCZ
commented
Sep 22, 2022
- Allow to send event PRESENCE_CHECK_INIT during PRESENCE_CHECK_IN_PROGRESS
- Remove IProovConst
- Add another initPresenceCheck to repeatPresenceCheckStartTest
- Improve logging of IdentityVerification phase changes
banterCZ
commented
Sep 22, 2022
| @@ -130,6 +132,7 @@ public void checkDocumentUploadLimit(OwnerId ownerId, IdentityVerificationEntity | |||
| identityVerification.setTimestampLastUpdated(ownerId.getTimestamp()); | |||
| identityVerification.setTimestampFailed(ownerId.getTimestamp()); | |||
| identityVerificationRepository.save(identityVerification); | |||
| logger.info("Switched to {}/FAILED; process ID: {}", identityVerification.getPhase(), identityVerification.getProcessId()); | |||
There was a problem hiding this comment.
Without extensive logging, it was difficult to debug this issue.
| /** | ||
| * Session parameter name of the verification token | ||
| */ | ||
| public static final String VERIFICATION_TOKEN = "iproov-verification-token"; |
There was a problem hiding this comment.
Simplify namespace, there is no need to have this constant public.
| @@ -317,6 +317,15 @@ private void configurePresenceCheckTransitions(StateMachineTransitionConfigurer< | |||
| .action(presenceCheckInitAction) | |||
| .target(OnboardingState.PRESENCE_CHECK_IN_PROGRESS) | |||
|
|
|||
| .and() | |||
| .withExternal() | |||
| .source(OnboardingState.PRESENCE_CHECK_IN_PROGRESS) | |||
There was a problem hiding this comment.
The main change! Allow to send PRESENCE_CHECK_INIT event during PRESENCE_CHECK_IN_PROGRESS, respectively to call /api/identity/presence-check/init to get iProov token. cc @kober32
| "Missing presence check verification token in session 1" | ||
| ); | ||
|
|
||
| SessionInfo sessionInfo2 = provider.startPresenceCheck(ownerId); | ||
| initPresenceCheck(ownerId); |
There was a problem hiding this comment.
To be sure to call init at iProov twice, but works anyway.
romanstrobl
approved these changes
Sep 22, 2022
- Allow to send event PRESENCE_CHECK_INIT during PRESENCE_CHECK_IN_PROGRESS - Remove IProovConst - Add another initPresenceCheck to repeatPresenceCheckStartTest - Improve logging of IdentityVerification phase changes
8e920db to
d56f093
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.