Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #269: Separate OTP failure handling by OTP type #332

Merged
merged 5 commits into from
Sep 6, 2022
Merged

Fix #269: Separate OTP failure handling by OTP type #332

merged 5 commits into from
Sep 6, 2022

Conversation

romanstrobl
Copy link
Member

This pull request contains following changes which are required for #269:

  • identity verification restart in case maxFailedAttemptsOtp is reached
  • OTP verification during SCA step allows multiple OTP verification attempts instead of just one
  • improved calculation of remaining attempts for OTP verification
  • refactoring of entity, repository and service classes into common module due to dependencies for the identity verification restart logic

@romanstrobl romanstrobl added the enhancement New feature or request label Aug 29, 2022
@romanstrobl romanstrobl requested a review from banterCZ August 29, 2022 18:04
@romanstrobl romanstrobl self-assigned this Aug 29, 2022
@romanstrobl romanstrobl mentioned this pull request Aug 29, 2022
Merged
banterCZ
banterCZ approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@banterCZ banterCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just little comments to consider.

...ng-common/src/main/java/com/wultra/app/onboardingserver/common/service/CommonOtpService.java Show resolved Hide resolved
...ng-common/src/main/java/com/wultra/app/onboardingserver/common/service/CommonOtpService.java Outdated Show resolved Hide resolved
...ng-common/src/main/java/com/wultra/app/onboardingserver/common/service/CommonOtpService.java Outdated Show resolved Hide resolved
...ng-common/src/main/java/com/wultra/app/onboardingserver/common/service/CommonOtpService.java Outdated Show resolved Hide resolved
...ng-common/src/main/java/com/wultra/app/onboardingserver/common/service/CommonOtpService.java Outdated Show resolved Hide resolved
...in/java/com/wultra/app/onboardingserver/common/service/IdentityVerificationLimitService.java Outdated Show resolved Hide resolved
...in/java/com/wultra/app/onboardingserver/common/service/IdentityVerificationLimitService.java Outdated Show resolved Hide resolved
@romanstrobl romanstrobl marked this pull request as ready for review September 6, 2022 11:57
@romanstrobl romanstrobl merged commit 9929ca8 into develop Sep 6, 2022
@romanstrobl romanstrobl deleted the issues/269-separate-otp-failure-handling-type branch September 6, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banterCZ banterCZ banterCZ approved these changes

Assignees

@romanstrobl romanstrobl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romanstrobl @banterCZ