Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #320: Use fake OTP authentication in case user does not exist #321

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Fix #320: Use fake OTP authentication in case user does not exist #321

merged 2 commits into from
Aug 24, 2022

Conversation

banterCZ
Copy link
Member

No description provided.

@banterCZ banterCZ requested a review from romanstrobl August 23, 2022 10:38
@banterCZ banterCZ mentioned this pull request Aug 23, 2022
Merged
romanstrobl
romanstrobl requested changes Aug 24, 2022
View reviewed changes
Copy link
Member

@romanstrobl romanstrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not like the hardcoded fake- constant. I think we can use a null value for user ID for this case as we used it in the powerauth-webflow project.

...arding/src/main/java/com/wultra/app/onboardingserver/impl/service/OnboardingServiceImpl.java Outdated Show resolved Hide resolved
@banterCZ
Use null user instead of fake prefix
dc088be 
Remove activation (if present) during onboarding cleanup
@banterCZ banterCZ requested a review from romanstrobl August 24, 2022 12:57
romanstrobl
romanstrobl approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@romanstrobl romanstrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@banterCZ banterCZ merged commit 6172afb into develop Aug 24, 2022
@banterCZ banterCZ deleted the issues/320-fake-otp branch August 24, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanstrobl romanstrobl romanstrobl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@banterCZ @romanstrobl