Fix #498: Suspicious filename records in table es_document_verificati…

…on (#525) Rename selfie filename to person_photo_from_iProov.jpg
wultra · Nov 15, 2022 · 73fe62b · 73fe62b
1 parent f634923
commit 73fe62b
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/...va/com/wultra/app/onboardingserver/common/database/entity/DocumentVerificationEntity.java b/...va/com/wultra/app/onboardingserver/common/database/entity/DocumentVerificationEntity.java
@@ -90,7 +90,7 @@ public class DocumentVerificationEntity implements Serializable {
     private String otherSideId;
 
     /**
-     * Name of provider which performed the verification
+     * Name identifying {@code DocumentVerificationProvider}.
      */
     @Column(name = "provider_name")
     private String providerName;

diff --git a/...ding/src/main/java/com/wultra/app/onboardingserver/impl/service/PresenceCheckService.java b/...ding/src/main/java/com/wultra/app/onboardingserver/impl/service/PresenceCheckService.java
@@ -168,13 +168,13 @@ public void checkPresenceVerification(OwnerId ownerId,
         }
         logger.debug("Processing a result of an accepted presence check, {}", ownerId);
 
-        Image photo = result.getPhoto();
+        final Image photo = result.getPhoto();
         if (photo == null) {
             throw new PresenceCheckException("Missing person photo from presence verification, " + ownerId);
         }
         logger.debug("Obtained a photo from the result, {}", ownerId);
 
-        SubmittedDocument submittedDoc = new SubmittedDocument();
+        final SubmittedDocument submittedDoc = new SubmittedDocument();
         // TODO use different random id approach
         submittedDoc.setDocumentId(
                 Ascii.truncate("selfie-photo-" + ownerId.getActivationId(), 36, "...")

diff --git a/...ultra/app/onboardingserver/presencecheck/iproov/provider/IProovPresenceCheckProvider.java b/...ultra/app/onboardingserver/presencecheck/iproov/provider/IProovPresenceCheckProvider.java
@@ -56,6 +56,7 @@ public class IProovPresenceCheckProvider implements PresenceCheckProvider {
      * Session parameter name of the verification token
      */
     private static final String VERIFICATION_TOKEN = "iProovVerificationToken";
+    private static final String SELFIE_FILENAME = "person_photo_from_iProov.jpg";
 
     private final ObjectMapper objectMapper;
 
@@ -257,7 +258,7 @@ private static Image parseImage(final String frame) {
         final byte[] photoData = Base64.getDecoder().decode(frameJpeg);
 
         final Image photo = new Image();
-        photo.setFilename("person_photo_from_id.jpg");
+        photo.setFilename(SELFIE_FILENAME);
         photo.setData(photoData);
         return photo;
     }

diff --git a/...tra/app/onboardingserver/presencecheck/mock/provider/WultraMockPresenceCheckProvider.java b/...tra/app/onboardingserver/presencecheck/mock/provider/WultraMockPresenceCheckProvider.java
@@ -45,6 +45,7 @@ public class WultraMockPresenceCheckProvider implements PresenceCheckProvider {
      * Session parameter name of the verification token
      */
     private static final String VERIFICATION_TOKEN = "mockVerificationToken";
+    private static final String SELFIE_FILENAME = "person_photo_from_mock.jpg";
 
     /**
      * Service constructor.
@@ -84,7 +85,7 @@ public PresenceCheckResult getResult(OwnerId id, SessionInfo sessionInfo) {
         if (photo.getData() == null) {
             photo.setData(new byte[]{});
         }
-        photo.setFilename("selfie_photo.jpg");
+        photo.setFilename(SELFIE_FILENAME);
 
         PresenceCheckResult result = new PresenceCheckResult();
         result.setStatus(PresenceCheckStatus.ACCEPTED);