Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract only shared roles from the user's role list when login to a shared app #2703

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ShanChathusanda93
Copy link
Contributor

Proposed changes in this pull request

  • $subject
  • When login with organization SSO flow, the user's role list will be extracted from the userinfo call.
  • When getting the roles, only shared roles will be picked if the accessing app is a shared app

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 45.45455% with 18 lines in your changes missing coverage. Please review.

Project coverage is 56.53%. Comparing base (3d191a2) to head (64415f6).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
...carbon/identity/oauth/endpoint/util/ClaimUtil.java 45.45% 11 Missing and 7 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2703      +/-   ##
============================================
- Coverage     56.54%   56.53%   -0.02%     
- Complexity     8543     8555      +12     
============================================
  Files           654      654              
  Lines         48522    48607      +85     
  Branches      10131    10144      +13     
============================================
+ Hits          27436    27479      +43     
- Misses        17172    17228      +56     
+ Partials       3914     3900      -14     
Flag Coverage Δ
unit 39.93% <45.45%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShanChathusanda93 ShanChathusanda93 force-pushed the shared-apps-to-shared-roles-branch branch from 84abe2b to 64415f6 Compare February 14, 2025 09:04
@AnuradhaSK
Copy link
Contributor

For the ID token is this properly handled ? Hope this is the place

@jenkins-is-staging
Copy link

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13326284949
Status: failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants