Bug Fix for Single-layer UCM Green Roof Option #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al processes for the single-layer UCM) to correct a bug in the green roof module
|
@kkeene44 In the description, should "disclosure" be "closure" or "non-closure"? I actually have no idea, but "disclosure" sounds strange in this context. |
|
@mgduda done. |
mkavulich
approved these changes
Mar 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: module_sf_urban.F, green_roof option,
SOURCE: Jiachun Yang, Princeton University
DESCRIPTION OF CHANGES: There was a problem in the green roof option within module_sf_urban.F. Subsurface temps of the green roof failed to converge at very dry conditions with very small time steps. The bug occurs because surface and subsurface temps are updated at the same time in the iteration loop, which leads to a surface energy non-closure problem. The modifications provided by the developer of this particular part of the module correct this.
LIST OF MODIFIED FILES:
M phys/module_sf_urban.F
TESTS CONDUCTED: regression tests pass. Per Mike Barlage, we trust this modification and he is okay with implementing it.