v1.0.1

- Prevent JS asset rendering on frontend outside CP
wrav · Dec 6, 2018 · f64944b · f64944b
1 parent da0219c
commit f64944b
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Simple Sharing Changelog
 
+## 1.0.1 - 2018-12-07
+
+### Updated
+- Prevent JS asset rendering on frontend
+
 ## 1.0.0 - 2018-11-14
 
 ### Added

diff --git a/composer.json b/composer.json
@@ -2,7 +2,7 @@
     "name": "wrav/simplesharing",
     "description": "Simple Sharing generates social media share links within CP entry pages, allowing you to quickly & easily share entries.",
     "type": "craft-plugin",
-    "version": "1.0.0",
+    "version": "1.0.1",
     "keywords": [
         "craft",
         "cms",

diff --git a/releases.json b/releases.json
@@ -1,4 +1,12 @@
 [
+    {
+        "version": "1.0.1",
+        "downloadUrl": "https://github.com/wrav/simple-sharing/archive/master.zip",
+        "date": "2018-12-07:00:00+10:30",
+        "notes": [
+            "[Updated] Prevent JS asset rendering on frontend"
+        ]
+    }.
     {
         "version": "1.0.0",
         "downloadUrl": "https://github.com/wrav/simple-sharing/archive/master.zip",
@@ -7,4 +15,4 @@
             "[Added] Initial release and migration from previous project"
         ]
     }
-]
+]
diff --git a/src/SimpleSharing.php b/src/SimpleSharing.php
@@ -76,9 +76,11 @@ function (PluginEvent $event) {
             View::class,
             View::EVENT_END_PAGE,
             function(Event $event) {
-                $url = Craft::$app->assetManager->getPublishedUrl('@wrav/simplesharing/assetbundles/simplesharing/dist/js/SimpleSharing.js', true);
+                if (Craft::$app->getRequest()->getIsCpRequest()) {
+                    $url = Craft::$app->assetManager->getPublishedUrl('@wrav/simplesharing/assetbundles/simplesharing/dist/js/SimpleSharing.js', true);
 
-                echo "<script src='$url'></script>";
+                    echo "<script src='$url'></script>";
+                }
             }
         );