Add article for JVM MSVC runtime error #2947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ece72d6 to
36880e7
Compare
36880e7 to
5607026
Compare
|
|
||
| It can also be done by putting ``gradle.properties`` in the project root with the following contents (where YEAR is the current WPILib installation): | ||
|
|
||
| .. warning:: This will only work if you only use your project on Windows, as the location is hardcoded to the location on Windows. |
There was a problem hiding this comment.
Mention what the Linux path is rather than limiting this to Windows
There was a problem hiding this comment.
I would rather just either leave this as is, or remove this option entirely.
Basically what this is saying is that if you do this, your project will only work on Windows. We have no way around that.
Linux and macOS won't need a worked around JDK like this, so the solution for those is to just not do this.
There was a problem hiding this comment.
I added a recommendation not to check into VCS
e9c7e7e to
5dd84e7
Compare
ThadHouse
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.