use sphinx-design tabs #2363
Merged
use sphinx-design tabs #2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sciencewhiz
previously requested changes
Oct 25, 2023
|
Should be done/ ready for review |
|
It would be good to add something to the style guide about how to use tabs. It's not there now, but since the methods are changing I think it makes sense to document now |
|
Do the |
|
I had tested a few and they did, but I haven't tried multiple browsers |
|
sphinx-tabs can be removed as a dependency for poetry, right? |
yes |
|
I added to style guide and fixed the conflicts |
Daltz333
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incomplete, I still have 15 files to go
however the first portion is done and I'm heading to bed