Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Trust Index Google Widget CSS from LazyLoad for CSS Background Images #7055

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

wordpressfan
Copy link
Contributor

Description

Fixes #6957

We add those two exclusions globally

trustindex-google-widget.css
cdn.trustindex.io

As mentioned here by product team.

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Detailed scenario

Everything is mentioned in the issue itself, we just added the exclusion itself here.

Technical description

We added those mentioned two items to the lazyload background images exclusions list.

Documentation

Mentioned above

New dependencies

No

Risks

I hoped to add this as a third-party compatibility but I think this has a minimal effect.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

@wordpressfan wordpressfan self-assigned this Oct 23, 2024
@wordpressfan wordpressfan marked this pull request as ready for review October 23, 2024 13:15
@wordpressfan wordpressfan requested a review from a team October 23, 2024 13:17
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 815e6391 100.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (815e639) Report Missing Report Missing Report Missing
Head commit (fce9b3d) 37756 16603 43.97%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7055) 7 7 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@wordpressfan wordpressfan added this pull request to the merge queue Oct 23, 2024
Merged via the queue into develop with commit 8c1fed9 Oct 23, 2024
13 checks passed
@wordpressfan wordpressfan deleted the fix/6957-add-lazyload-exclusions branch October 23, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-exclude Trust Index Google Widget CSS from LazyLoad for CSS Background Images
2 participants