-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rocket scripts package for LCP Beacon #6771
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences🚀 Don’t miss a bit, follow what’s new on Codacy. Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working as expected (note: e2e lcp when run altogether, mobile fails then running mobile scenario only passed)
testrail-report-618.pdf
PR6771 npm run test lcp.txt
PR6771 mobile only npm.txt
Part of https://github.com/wp-media/wpr-inspector/issues/24
Here we are changing the way we generate the beacon scripts, so we created a new package here: https://github.com/wp-media/rocket-scripts to have the source code of beacon script(s) and build their files and here in WPR for example we will just copy the files from their dist into our js directory.
This will a lot in adding JS tests there, also will make WPR repo cleaner so any change needed in beacon scripts (and we may add more scripts in the future) so we will need to go to this repo and do whatever needed.
Todo