Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rocket scripts package for LCP Beacon #6771

Merged
merged 6 commits into from
Jul 18, 2024

Conversation

wordpressfan
Copy link
Contributor

@wordpressfan wordpressfan commented Jul 11, 2024

Part of https://github.com/wp-media/wpr-inspector/issues/24

Here we are changing the way we generate the beacon scripts, so we created a new package here: https://github.com/wp-media/rocket-scripts to have the source code of beacon script(s) and build their files and here in WPR for example we will just copy the files from their dist into our js directory.

This will a lot in adding JS tests there, also will make WPR repo cleaner so any change needed in beacon scripts (and we may add more scripts in the future) so we will need to go to this repo and do whatever needed.

Todo

  • Add unit tests for rocket-scripts repo
  • Divide the beacon class into smaller modules to make it easier to create a new file that uses the current code.

Copy link

codacy-production bot commented Jul 11, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for d70151f1 (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d70151f) Report Missing Report Missing Report Missing
Head commit (d8a3b49) 37376 14549 38.93%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6771) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@wordpressfan wordpressfan marked this pull request as ready for review July 12, 2024 07:04
Copy link
Contributor

@Khadreal Khadreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wordpressfan wordpressfan added this to the 3.16.3 milestone Jul 16, 2024
@Mai-Saad Mai-Saad self-requested a review July 18, 2024 11:44
Copy link
Contributor

@Mai-Saad Mai-Saad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working as expected (note: e2e lcp when run altogether, mobile fails then running mobile scenario only passed)
testrail-report-618.pdf
PR6771 npm run test lcp.txt
PR6771 mobile only npm.txt

@Mai-Saad Mai-Saad added this pull request to the merge queue Jul 18, 2024
Merged via the queue into develop with commit d9d976c Jul 18, 2024
13 checks passed
@Mai-Saad Mai-Saad deleted the feature/use-rocket-scripts-package branch July 18, 2024 14:03
@remyperona remyperona mentioned this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants