Closes #264 #265
Merged
Closes #264 #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeekPress
reviewed
Dec 21, 2016
| add_filter( 'wr2x_img_url', 'rocket_cdn_on_images_from_wp_retina_x2' ); | ||
| function rocket_cdn_on_images_from_wp_retina_x2( $url ) { | ||
| global $wr2x_admin; | ||
| if ( $wr2x_admin->is_pro() ) { |
There was a problem hiding this comment.
Check before if the method exists with method_exists() function to avoid php error if the method doesn't exist in the future
GeekPress
reviewed
Dec 21, 2016
| */ | ||
| add_filter( 'wr2x_img_retina_url', '__rocket_cdn_on_images_from_wp_retina_x2' ); | ||
| add_filter( 'wr2x_img_url', '__rocket_cdn_on_images_from_wp_retina_x2' ); | ||
| function __rocket_cdn_on_images_from_wp_retina_x2( $url ) { |
There was a problem hiding this comment.
Don't forget to deprecated this function __rocket_cdn_on_images_from_wp_retina_x2() as it's renamed rocket_cdn_on_images_from_wp_retina_x2() without __ at the beginning
There was a problem hiding this comment.
A question about PHP7, if we add this function is the deprecated, it will still display an error because we will declare a function with double underscore?
There was a problem hiding this comment.
Most probably yes, we need to remove them all completely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move WP Retina code to 3rd party and improve resilience