Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beacon script can be injected multiple times when there are multiple </body> in the page. #6960

Closed
MathieuLamiot opened this issue Sep 8, 2024 · 0 comments · Fixed by #7231
Closed

Beacon script can be injected multiple times when there are multiple </body> in the page. #6960

MathieuLamiot opened this issue Sep 8, 2024 · 0 comments · Fixed by #7231
Assignees
@Khadreal
Labels
module: Beacon priority: low Issues that can wait quick win severity: minor Defect that does not affect functionality
Milestone
3.18.1

Comments

@MathieuLamiot
Copy link
Contributor

Context

https://wp-media.slack.com/archives/CUT7FLHF1/p1725795776110169?thread_ts=1725624439.071799&cid=CUT7FLHF1

The impact is that the beacon executes multiple times, and performs multiple AJAX calls. Only the first one is useful.

Expected behavior

The beacon is injected at most once.

Acceptance Criteria
On a page with multiple , the beacon is injected only once.
@MathieuLamiot MathieuLamiot added module: Beacon severity: minor Defect that does not affect functionality labels Sep 8, 2024
@piotrbak piotrbak added priority: low Issues that can wait quick win labels Sep 27, 2024
Khadreal added a commit that referenced this issue Jan 16, 2025
@Khadreal
:closes: #6960 Fix issue with multiple body tag in the page
12c65f1
@Khadreal Khadreal mentioned this issue Jan 16, 2025
Merged
8 tasks
@Khadreal Khadreal self-assigned this Jan 16, 2025
@MathieuLamiot MathieuLamiot mentioned this issue Jan 20, 2025
Merged
1 task
@piotrbak piotrbak added this to the 3.18.1 milestone Jan 20, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 27, 2025
@Khadreal @jeawhanlee
Fix #6960 Beacon script can be injected multiple times when there are…
426d736 
… multiple </body> in the page. (#7231)

Co-authored-by: Michael Lee <michaelleemichaellee408@gmail.com>
@wordpressfan wordpressfan mentioned this issue Jan 29, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Khadreal Khadreal

Labels
module: Beacon priority: low Issues that can wait quick win severity: minor Defect that does not affect functionality
Projects
None yet
Milestone
3.18.1
3 participants
@Khadreal @MathieuLamiot @piotrbak