Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added phpcs and some fixes #36

Merged
merged 2 commits into from
Jul 20, 2024
Merged

Added phpcs and some fixes #36

merged 2 commits into from
Jul 20, 2024

Conversation

CrochetFeve0251
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed/closed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #32

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Is the solution different from the one proposed during the grooming?

Please describe in this section if there is any change to the solution, and why.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

Please delete the options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@CrochetFeve0251 CrochetFeve0251 self-assigned this Jul 20, 2024
@CrochetFeve0251 CrochetFeve0251 merged commit ab2a816 into v1 Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHPCS should be passing without any change when installing Launchpad
1 participant