Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update install-package-tests #87

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Update install-package-tests #87

merged 1 commit into from
Jun 4, 2020

Conversation

vbelolapotkov
Copy link
Contributor

Proposed changes

  • Pass root password via env variable.
  • Fallback to requesting password for each command.
  • Fix granting privileges for MySQL 8.0. See here.

Testing instructions

  • Install MySQL 8.0
  • Clone wp-cli-dev
  • Install its composer dependencies.
  • Enter one of the project folders, e.g. wp-cli
  • Run DB_PASSWORD=root_password_here composer prepare-tests. It should run without errors.

@vbelolapotkov
Update install-package-tests
0e65132 
Pass root password via env variable. Fallback to requesting password
for each command.
@vbelolapotkov vbelolapotkov requested a review from a team as a code owner June 4, 2020 14:48
@schlessera schlessera added this to the 2.1.11 milestone Jun 4, 2020
@schlessera schlessera merged commit 2faff80 into wp-cli:master Jun 4, 2020
schlessera added a commit that referenced this pull request Jan 5, 2022
@schlessera
Merge pull request #87 from vbelolapotkov/update/install-package-tests
11b524c 
Update install-package-tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlessera schlessera schlessera approved these changes

Assignees
No one assigned
Labels
scope:testing
Projects
None yet
Milestone
2.1.11
Development

Successfully merging this pull request may close these issues.
2 participants
@vbelolapotkov @schlessera