Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable WP Cron by default for Behat tests #28

Merged
merged 3 commits into from
Nov 17, 2018

Conversation

schlessera
Copy link
Member

Fixes #27

@schlessera schlessera added bug Something isn't working scope:testing labels Nov 17, 2018
@schlessera schlessera added this to the 2.1.0 milestone Nov 17, 2018
@schlessera schlessera requested a review from a team November 17, 2018 15:04
@@ -741,10 +741,14 @@ public function install_wp( $subdir = '' ) {

$subdir = $this->replace_variables( $subdir );

// Disable WP Cron by default to avoid bogus HTTP requests in CLI context.
$env = self::get_process_env_variables();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$env doesn't seem to be used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right, left-over from something I tested (providing an override).

@ocean90
Copy link

ocean90 commented Nov 20, 2018

wp-cli/cron-command#36 fixes the broken test for wp cron test.

schlessera added a commit that referenced this pull request Jan 5, 2022
Disable WP Cron by default for Behat tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working scope:testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants