Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Behat binaries #138

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Improve Behat binaries #138

merged 1 commit into from
Nov 23, 2021

Conversation

schlessera
Copy link
Member

This PR:

  1. Changes the check for bailing early on Behat execution from the features/ directory to the behat.yml file. Fixes Improve run-behat-tests for custom setups #126 .
  2. Changes --rerun usage to take changes from Behat v2 to Behat v3 into consideration.
  3. Makes rerun-behat-tests reuse run-behat-tests, to avoid duplicating all of the logix.

@schlessera schlessera requested a review from a team as a code owner November 23, 2021 22:10
@schlessera schlessera added bug Something isn't working scope:testing labels Nov 23, 2021
@schlessera schlessera added this to the 3.0.19 milestone Nov 23, 2021
@schlessera schlessera merged commit bd8e26d into master Nov 23, 2021
@schlessera schlessera deleted the fix/126-check-behat-config branch November 23, 2021 22:14
schlessera added a commit that referenced this pull request Jan 5, 2022
@schlessera
Merge pull request #138 from wp-cli/fix/126-check-behat-config
ecb9cad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working scope:testing
Projects
None yet
Milestone
3.0.19
Development

Successfully merging this pull request may close these issues.

Improve run-behat-tests for custom setups
1 participant
@schlessera