-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added extra debugging information. #133
Conversation
@janw-me The idea behind the check for the Not sure anymore whether this is the best approach, but it is what we currently have, and changing it will require lots of coordination work again. |
@schlessera If this changes breaks anything drop it like no mic has ever been dropped before. But in al seriousness I'm not sure I understand what you're suggesting. |
Chang Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
Yes, I'm not sure the check is in the right place. The As you experienced yourself, this causes explicit calls to run a certain test suite to just silently fail. |
Also shouldn't the
exit
return 1?As it is an error.