Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extra debugging information. #133

Merged
merged 5 commits into from
Oct 11, 2021
Merged

Conversation

janw-me
Copy link
Member

@janw-me janw-me commented Oct 8, 2021

Also shouldn't the exit return 1?
As it is an error.

@janw-me janw-me requested a review from a team as a code owner October 8, 2021 11:51
@schlessera
Copy link
Member

@janw-me The idea behind the check for the features folder was that we can have unified composer test for all repositories, and it will then conditionally run Behat only if Behat tests are present. This enables unified GHA workflows that are automatically synced across all repositories.

Not sure anymore whether this is the best approach, but it is what we currently have, and changing it will require lots of coordination work again.

bin/run-behat-tests Outdated Show resolved Hide resolved
bin/run-behat-tests Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@janw-me
Copy link
Member Author

janw-me commented Oct 10, 2021

@schlessera If this changes breaks anything drop it like no mic has ever been dropped before.

But in al seriousness I'm not sure I understand what you're suggesting.
"whether this is the best approach" Are you refering to the way behat is only run if a features folder is present?
Because if this is because of GHA that's fine as long as a message is thrown that new(/rare)-contributers help along the way.

janw-me and others added 2 commits October 10, 2021 16:20
Chang

Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
@schlessera
Copy link
Member

But in al seriousness I'm not sure I understand what you're suggesting.
"whether this is the best approach" Are you refering to the way behat is only run if a features folder is present?
Because if this is because of GHA that's fine as long as a message is thrown that new(/rare)-contributers help along the way.

Yes, I'm not sure the check is in the right place. The composer test command should probably have script that checks which tests to run, and then only run them conditionally, instead of each test doing such a check.

As you experienced yourself, this causes explicit calls to run a certain test suite to just silently fail.

@schlessera schlessera merged commit fe6297a into wp-cli:master Oct 11, 2021
@wojsmol wojsmol mentioned this pull request Oct 11, 2021
schlessera added a commit that referenced this pull request Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants