Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gherkin linting #189

Merged
merged 3 commits into from
May 10, 2021

Conversation

Lewiscowles1986
Copy link
Contributor

Proposal

Fixes #82

  • Uses GitHub action (can be merged into single file. Kept separate so potential merge conflicts can be avoided
  • Uses NPM / JS (can pivot and search for something else if something suitable exists)
  • Adds config file (which may be in need of iteration, it was borrowed from Moodle, but had some spelling mistakes I fixed to avoid errors in a likely outdated file)

Let me know if this is unsuitable. If you really want to have fun and test this:

  1. clone the branch
  2. npm install
  3. npm run lint && echo success || echo failure (should contain "success" and not contain "failure")
  4. change the indentation of a .feature file (I tested by removing all indentation)
  5. npm run lint && echo success || echo failure (should contain "failure")

@Lewiscowles1986 Lewiscowles1986 requested a review from a team as a code owner November 18, 2020 07:13
@schlessera schlessera force-pushed the feature/gherkin-linting branch from b1a3b3b to 6d47d7f Compare May 10, 2021 07:48
@schlessera schlessera added this to the 2.0.0 milestone May 10, 2021
@schlessera
Copy link
Member

Thanks for the PR, @Lewiscowles1986 !

@schlessera schlessera merged commit 0459270 into wp-cli:master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a linter for Behat .feature files
2 participants