Improve URL validation for scaffold package readme section

wp-cli · Mar 13, 2024 · 1778818 · 1778818
1 parent 5655856
commit 1778818
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/ScaffoldPackageCommand.php b/src/ScaffoldPackageCommand.php
@@ -399,7 +399,7 @@ public function package_readme( $args, $assoc_args ) {
 				$v = '';
 				if ( isset( $composer_obj['extra']['readme'][ $section ][ $k ] ) ) {
 					$v = $composer_obj['extra']['readme'][ $section ][ $k ];
-					if ( false !== strpos( $v, '://' ) ) {
+					if ( filter_var( $v, FILTER_VALIDATE_URL ) === $v ) {
 						$response = Utils\http_request( 'GET', $v );
 						$v        = $response->body;
 					} elseif ( preg_match( $ext_regex, $v ) ) {