Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RecursiveDataStructureTraverser #442

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

schlessera
Copy link
Member

This PR removes the RecursiveDataStructureTraverser class from the wp-cli/entity-command package and sets the package up to reuse it from the framework instead.

Note: Pushing first with the removal only to show how it fails before fixing the distribution aspect of it.

@schlessera schlessera requested a review from a team as a code owner November 14, 2023 10:43
@schlessera
Copy link
Member Author

@danielbachhuber , @swissspidy some added context here to explain how this works:
The new \WP_CLI\Traverser\RecursiveDataStructureTraverser in the framework is not yet part of a tagged release, it is only included in the main branch so far.

However, given that:

... we can tell Composer to pull in version 2.10+ of the framework. It will accept dev-main to represent a non-stable version of 2.10, and the dev stability requirements will allow that version to be used for wp-cli/entity-command's requirements => a6d96ee#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R15

This effectively means that the wp-cli/entity-command will pull in dev-main and assume it is v2.10+ (and all other packages have been set up to work correctly with this).

Then, once we will release a tagged version 2.10.0 for the wp-cli/wp-cli framework, the fact that the wp-cli/entity-command has prefer-stable set to true means that it will revert back to a stable, tagged version of 2.10.0 and all future versions as soon as possible =>

"prefer-stable": true,

/cc @thelovekesh

@schlessera schlessera added this to the 2.5.7 milestone Nov 14, 2023
@schlessera schlessera merged commit e118963 into main Nov 14, 2023
36 checks passed
@schlessera schlessera deleted the fix/switch-to-framework-recursive-traverser branch November 14, 2023 11:52
@danielbachhuber
Copy link
Member

@schlessera Thanks for explaining all of that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants