Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to WPCS v3 #38

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Update to WPCS v3 #38

merged 3 commits into from
Sep 1, 2023

Conversation

danielbachhuber
Copy link
Member

@danielbachhuber danielbachhuber added this to the 2.0.2 milestone Sep 1, 2023
@danielbachhuber danielbachhuber requested a review from a team September 1, 2023 11:38
@swissspidy
Copy link
Member

Is this even used here? 🤔

@danielbachhuber
Copy link
Member Author

Is this even used here? 🤔

@swissspidy Assuming yes because this is the automated tests repo, but let's see 10df271

@wojsmol
Copy link
Contributor

wojsmol commented Sep 1, 2023

Yes, because this command are defined in wp-cli-test package

@danielbachhuber
Copy link
Member Author

Definitely yes 😁

@swissspidy
Copy link
Member

Ah I see, it's needed for setting up the database etc. But not for PHPCS, as there aren't really any PHP files.

@danielbachhuber danielbachhuber merged commit ae9bfdf into main Sep 1, 2023
@danielbachhuber danielbachhuber deleted the update-wp-cli-tests-v4 branch September 1, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees
No one assigned
Labels
scope:testing
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@danielbachhuber @swissspidy @wojsmol