Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not test WP trunk on PHP 5.6 #36

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Do not test WP trunk on PHP 5.6 #36

merged 1 commit into from
Jul 13, 2023

Conversation

swissspidy
Copy link
Member

@swissspidy swissspidy commented Jul 12, 2023

This is because WP trunk now requires PHP 7.0.

There already is a test covering trunk + PHP 7.0

See wp-cli/wp-cli#5810

This is because WP trunk now requires PHP 7.0.

There already is a test covering trunk + PHP 7.0
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Noting that we're working on resolving the other test failures right now.

@danielbachhuber danielbachhuber merged commit dee71a0 into main Jul 13, 2023
@danielbachhuber danielbachhuber deleted the no-php56-on-trunk branch July 13, 2023 12:01
@swissspidy swissspidy added this to the 2.0.2 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants