Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node/solana: add shim support #11

Merged
merged 4 commits into from
Jan 22, 2025
Merged

node/solana: add shim support #11

merged 4 commits into from
Jan 22, 2025

Conversation

bruce-riley
Copy link
Collaborator

@bruce-riley bruce-riley commented Jan 15, 2025 •
edited
Loading

Don't be alarmed by the size of this PR. A thousand lines of it are tests, and most of that is JSON encoded transactions.

@bruce-riley bruce-riley force-pushed the node/solana_add_shim_support branch 6 times, most recently from bc8ba62 to f236c1a Compare January 16, 2025 22:15
@bruce-riley bruce-riley force-pushed the node/solana_add_shim_support branch 4 times, most recently from 970c9fc to 048ba4d Compare January 17, 2025 19:30
@evan-gray evan-gray marked this pull request as ready for review January 21, 2025 19:04
@bruce-riley bruce-riley force-pushed the node/solana_add_shim_support branch from 2a58da7 to 94cfc9c Compare January 22, 2025 15:55
@bruce-riley bruce-riley requested a review from evan-gray January 22, 2025 16:15
@evan-gray evan-gray changed the title Node/solana add shim support node/solana: add shim support Jan 22, 2025
evan-gray
evan-gray requested changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small nits

node/pkg/watchers/solana/shim.go Outdated Show resolved Hide resolved
node/pkg/watchers/solana/shim.go Outdated Show resolved Hide resolved
node/pkg/watchers/solana/shim.go Outdated Show resolved Hide resolved
node/pkg/watchers/solana/shim.go Outdated Show resolved Hide resolved
node/pkg/watchers/solana/shim.go Outdated Show resolved Hide resolved
@evan-gray evan-gray merged commit 50c6f0c into svm-shims Jan 22, 2025
26 of 29 checks passed
@evan-gray evan-gray deleted the node/solana_add_shim_support branch January 22, 2025 17:56
evan-gray pushed a commit that referenced this pull request Jan 24, 2025
@bruce-riley @evan-gray
node/solana: add shim support (#11)
b31d886 
* Node/Solana: Add shim support

* Code review rework

* Tweaks after rebase

* More rework
@evan-gray evan-gray mentioned this pull request Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-gray evan-gray evan-gray approved these changes

@panoel panoel Awaiting requested review from panoel panoel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bruce-riley @evan-gray