-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prometheus remote write to guardian and ccq #3497
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panoel
changed the title
node/pkg/telemetry: prometheus remote write
DRAFT: node/pkg/telemetry: prometheus remote write
Nov 3, 2023
Some of the files in this package are taking verbatim from Prometheus, right? Should we have a separate package / directory under this one that contains those files, so it will be obvious which files we probably don't want to touch? Just a thought. |
bruce-riley
reviewed
Nov 6, 2023
panoel
force-pushed
the
prometheus_remote_write
branch
from
November 10, 2023 12:55
4983757
to
9a4ab4e
Compare
bruce-riley
reviewed
Nov 10, 2023
panoel
force-pushed
the
prometheus_remote_write
branch
2 times, most recently
from
November 13, 2023 13:56
3b8af81
to
4dd9152
Compare
panoel
changed the title
DRAFT: node/pkg/telemetry: prometheus remote write
Add prometheus remote write to guardian and ccq
Nov 13, 2023
panoel
force-pushed
the
prometheus_remote_write
branch
2 times, most recently
from
November 13, 2023 15:42
2531356
to
be4b015
Compare
bruce-riley
force-pushed
the
prometheus_remote_write
branch
from
November 13, 2023 20:22
be4b015
to
835dd4e
Compare
panoel
force-pushed
the
prometheus_remote_write
branch
2 times, most recently
from
November 16, 2023 15:31
be4b015
to
d6248b9
Compare
bruce-riley
previously approved these changes
Nov 16, 2023
evan-gray
reviewed
Nov 20, 2023
panoel
force-pushed
the
prometheus_remote_write
branch
from
December 4, 2023 21:06
fa33724
to
4ccf800
Compare
panoel
force-pushed
the
prometheus_remote_write
branch
from
December 5, 2023 14:53
ee17fce
to
89c8dfb
Compare
bruce-riley
reviewed
Dec 5, 2023
panoel
force-pushed
the
prometheus_remote_write
branch
2 times, most recently
from
December 5, 2023 17:42
34a9165
to
3355297
Compare
panoel
force-pushed
the
prometheus_remote_write
branch
from
December 5, 2023 18:20
009516f
to
69a4f84
Compare
evan-gray
approved these changes
Dec 6, 2023
bruce-riley
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for the guardian and the ccq server to scrape their own prometheus metrics and send them to grafana.
The *.proto files were taken from Prometheus. But, they were heavily edited in order to be converted from gogo protobuf to the standard go protobuf