Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prometheus remote write to guardian and ccq #3497

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

panoel
Copy link
Contributor

@panoel panoel commented Nov 3, 2023

This PR adds the ability for the guardian and the ccq server to scrape their own prometheus metrics and send them to grafana.
The *.proto files were taken from Prometheus. But, they were heavily edited in order to be converted from gogo protobuf to the standard go protobuf

@panoel panoel changed the title node/pkg/telemetry: prometheus remote write DRAFT: node/pkg/telemetry: prometheus remote write Nov 3, 2023
@bruce-riley
Copy link
Contributor

Some of the files in this package are taking verbatim from Prometheus, right? Should we have a separate package / directory under this one that contains those files, so it will be obvious which files we probably don't want to touch? Just a thought.

node/pkg/telemetry/prom_remote_write/scrape.go Outdated Show resolved Hide resolved
node/cmd/guardiand/node.go Outdated Show resolved Hide resolved
node/pkg/telemetry/prom_remote_write/scrape.go Outdated Show resolved Hide resolved
node/pkg/telemetry/prom_remote_write/scrape.go Outdated Show resolved Hide resolved
node/pkg/telemetry/prom_remote_write/scrape.go Outdated Show resolved Hide resolved
node/pkg/telemetry/prom_remote_write/scrape.go Outdated Show resolved Hide resolved
node/pkg/telemetry/prom_remote_write/scrape.go Outdated Show resolved Hide resolved
node/pkg/telemetry/prom_remote_write/scrape.go Outdated Show resolved Hide resolved
node/pkg/telemetry/prom_remote_write/prom_test.go Outdated Show resolved Hide resolved
@panoel panoel force-pushed the prometheus_remote_write branch from 4983757 to 9a4ab4e Compare November 10, 2023 12:55
@panoel panoel force-pushed the prometheus_remote_write branch 2 times, most recently from 3b8af81 to 4dd9152 Compare November 13, 2023 13:56
@panoel panoel marked this pull request as ready for review November 13, 2023 14:39
@panoel panoel requested a review from kev1n-peters as a code owner November 13, 2023 14:39
@panoel panoel changed the title DRAFT: node/pkg/telemetry: prometheus remote write Add prometheus remote write to guardian and ccq Nov 13, 2023
@panoel panoel requested a review from bruce-riley November 13, 2023 14:39
@panoel panoel force-pushed the prometheus_remote_write branch 2 times, most recently from 2531356 to be4b015 Compare November 13, 2023 15:42
@bruce-riley bruce-riley force-pushed the prometheus_remote_write branch from be4b015 to 835dd4e Compare November 13, 2023 20:22
@panoel panoel force-pushed the prometheus_remote_write branch 2 times, most recently from be4b015 to d6248b9 Compare November 16, 2023 15:31
bruce-riley
bruce-riley previously approved these changes Nov 16, 2023
node/cmd/guardiand/node.go Outdated Show resolved Hide resolved
node/pkg/telemetry/prom_remote_write/prom_test.go Outdated Show resolved Hide resolved
node/pkg/telemetry/prom_remote_write/scrape.go Outdated Show resolved Hide resolved
proto/prometheus/v1/remote.proto Show resolved Hide resolved
proto/prometheus/v1/types.proto Show resolved Hide resolved
node/pkg/telemetry/prom_remote_write/scrape.go Outdated Show resolved Hide resolved
@panoel panoel force-pushed the prometheus_remote_write branch 2 times, most recently from 34a9165 to 3355297 Compare December 5, 2023 17:42
@panoel panoel force-pushed the prometheus_remote_write branch from 009516f to 69a4f84 Compare December 5, 2023 18:20
@panoel panoel requested a review from bruce-riley December 5, 2023 18:22
@panoel panoel merged commit dee0d15 into main Dec 6, 2023
21 of 22 checks passed
@panoel panoel deleted the prometheus_remote_write branch December 6, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants