Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proof generation #16

Merged
merged 6 commits into from
Dec 11, 2024
Merged

proof generation #16

merged 6 commits into from
Dec 11, 2024

Conversation

pdtfh
Copy link
Contributor

@pdtfh pdtfh commented Dec 10, 2024

  • Adds base support for generating ZKPs under the protocol.
  • Introduces a global Environment to identities to be able to distinguish between different sets.
  • The default proof process generation also fetches the Merkle inclusion proof from the relevant sign up sequencer.
  • Extends U256Wrapper to also parse hex strings

@pdtfh pdtfh requested a review from sevazhidkov December 10, 2024 13:17
sevazhidkov
sevazhidkov approved these changes Dec 10, 2024
View reviewed changes
Copy link

@sevazhidkov sevazhidkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

walletkit-core/src/merkle_tree.rs Outdated Show resolved Hide resolved
walletkit-core/src/merkle_tree.rs Outdated Show resolved Hide resolved
walletkit-core/src/credential_type.rs Outdated Show resolved Hide resolved
@pdtfh pdtfh merged commit 473852b into main Dec 11, 2024
5 checks passed
@pdtfh pdtfh deleted the proof branch December 11, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevazhidkov sevazhidkov sevazhidkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdtfh @sevazhidkov