Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proof context / external nullifier generation #12

Merged
merged 5 commits into from
Nov 22, 2024
Merged

proof context / external nullifier generation #12

merged 5 commits into from
Nov 22, 2024

Conversation

pdtfh
Copy link
Contributor

@pdtfh pdtfh commented Nov 21, 2024

Implements logic to generate external nullifier from a proof context struct.

  • Supports generating external nullifiers solely from app_ids.
  • Supports string-based actions (for off-chain use cases).
  • Supports Solidity-based custom actions.

@pdtfh pdtfh requested a review from sevazhidkov November 21, 2024 20:16
Base automatically changed from identity to main November 21, 2024 20:30
An error occurred while trying to automatically change base from identity to main November 21, 2024 20:30
sevazhidkov
sevazhidkov approved these changes Nov 21, 2024
View reviewed changes
Copy link

@sevazhidkov sevazhidkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damn, integrating solidity into integration is amazing. would be cool to continue that path with other stuff — e.g. proof validation, merkle tree insertion

walletkit-core/src/proof.rs Outdated Show resolved Hide resolved
@pdtfh pdtfh merged commit d42bfa9 into main Nov 22, 2024
4 checks passed
@pdtfh pdtfh deleted the ext-nullifier branch November 22, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevazhidkov sevazhidkov sevazhidkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdtfh @sevazhidkov