feat(telemetry): add opentelemetry support #346
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheButlah
requested changes
Jan 3, 2025
TheButlah
requested changes
Jan 8, 2025
|
|
||
| impl Drop for TelemetryShutdownHandler { | ||
| fn drop(&mut self) { | ||
| global::shutdown_tracer_provider(); |
There was a problem hiding this comment.
what happens if we aren't using opentelemetry at all (for example, if we only did with_journald but did not do with_opentelemetry)? Will this panic?
There was a problem hiding this comment.
No, it won't panic. The code is designed to safely handle cases where OpenTelemetry isn't used. If you only configure journald logging, the telemetry system will simply initialize without the OpenTelemetry components. This is achieved through Rust's Option type - when OpenTelemetry isn't configured, those components remain as None values and are safely skipped during initialization. The system will proceed with just the journald logging functionality working as expected.
This flexible design allows users to choose which telemetry features they need without worrying about dependencies on other components. You can start with basic logging and add OpenTelemetry later if needed, or just stick with logging if that's all your application requires.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.