IDP-818 - Handling running swashbuckle cli with a sdk greater than net7.0 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gcaya
commented
Jan 23, 2024
meziantou
reviewed
Jan 23, 2024
Co-authored-by: Gérald Barré <meziantou@users.noreply.github.com>
Co-authored-by: Gérald Barré <meziantou@users.noreply.github.com>
…napi-msbuild into feature/idp-818
meziantou
reviewed
Jan 23, 2024
Co-authored-by: Gérald Barré <meziantou@users.noreply.github.com>
Co-authored-by: Gérald Barré <meziantou@users.noreply.github.com>
meziantou
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
So Swashbuckle.AspNetCore.Cli targeted max framework .net7 for now. That created a problem when our task was used in a project tageting .net8 since only the .net8 runtime would be available and you would get an error.
So I modified the ProcessManager to be able to receive environment variables that will be passed to CliWrap and in the SwaggerManager we now tell the process running the swashbuckle cli to roll over to the latest major available.
I also upgraded our debuggerWebapi to target .net8, proof that the fix works.
Breaking changes
No
Additional checks