Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1028 #1029

Closed
wants to merge 2 commits into from
+15 −18
Closed

Feature/1028 #1029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b31eb44
swapped first child for first of type
Sep 30, 2022
674dee6
modified css selectors to work with first-of-type
Oct 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions packages/components/src/accordion/src/Accordion.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,6 @@
padding-bottom: var(--o-ui-sp-2);
}

.o-ui-accordion-header:first-child {
margin-top: 0;
}

/* TRIGGER */
.o-ui-accordion-trigger {
outline: transparent;
Expand Down Expand Up @@ -151,22 +147,22 @@
}

/* BORDERED | FIRST ITEM | BORDER RADIUS */
.o-ui-accordion-bordered .o-ui-accordion-header:first-of-type,
.o-ui-accordion-bordered .o-ui-accordion-header:first-of-type .o-ui-accordion-trigger {
.o-ui-accordion-bordered h3:first-of-type,
.o-ui-accordion-bordered h3:first-of-type .o-ui-accordion-trigger {
border-top-left-radius: var(--o-ui-sp-2);
border-top-right-radius: var(--o-ui-sp-2);
}

/* BORDERED | LAST ITEM | BORDER RADIUS */
.o-ui-accordion-bordered .o-ui-accordion-header:last-of-type,
.o-ui-accordion-bordered .o-ui-accordion-header:last-of-type .o-ui-accordion-trigger {
.o-ui-accordion-bordered h3:last-of-type,
.o-ui-accordion-bordered h3:last-of-type .o-ui-accordion-trigger {
border-bottom-left-radius: var(--o-ui-sp-2);
border-bottom-right-radius: var(--o-ui-sp-2);
}

/* BORDERED | LAST PANEL | BORDER RADIUS */
.o-ui-accordion-bordered .o-ui-accordion-panel:last-of-type,
.o-ui-accordion-bordered .o-ui-accordion-panel:last-of-type .o-ui-accordion-trigger {
.o-ui-accordion-bordered div:last-of-type,
.o-ui-accordion-bordered div:last-of-type .o-ui-accordion-trigger {
border-bottom-left-radius: var(--o-ui-sp-2);
border-bottom-right-radius: var(--o-ui-sp-2);
}
9 changes: 5 additions & 4 deletions packages/components/src/input-group/src/InputGroup.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@
}

/* ADDON */
.o-ui-input-group> :first-child:not(.o-ui-input-group-input) {
/* if first item is an addon */
.o-ui-input-group > div:first-of-type:not(.o-ui-input-group-input) {
margin-right: -1px;
}

Expand All @@ -45,13 +46,13 @@
}

/* ADDON | START */
.o-ui-input-group-input:not(:first-child),
.o-ui-input-group-input:not(:first-child) input {
.o-ui-input-group-addon + .o-ui-input-group-input,
.o-ui-input-group-addon + .o-ui-input-group-input input {
border-top-left-radius: 0;
border-bottom-left-radius: 0;
}

.o-ui-input-group-addon:first-child {
.o-ui-input-group div:first-of-type:not(.o-ui-input-group-input) {
border-top-right-radius: 0;
border-bottom-right-radius: 0;
flex-shrink: 0;
Expand Down
4 changes: 2 additions & 2 deletions packages/icons/docs/icon-gallery/details/Variants.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
margin-top: var(--o-ui-sp-4);
}

.o-ui-sb-gallery-item-variant-section-toggle:first-child {
.o-ui-sb-gallery-item-variant-section button:first-of-type {
margin-top: 0;
}

Expand All @@ -24,6 +24,6 @@
margin-bottom: 0 !important;
}

.o-ui-sb-gallery-item-variant-section-content .sbdocs-h4:first-child {
.o-ui-sb-gallery-item-variant-section-content h4:first-of-type {
margin-top: 0;
}
2 changes: 1 addition & 1 deletion packages/icons/docs/icon-gallery/details/Variants.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export function Variants({ iconDisplayName, variants }) {
return (
<>
<H2>Variants</H2>
<Tabs aria-label="Icon variants">
<Tabs aria-label="Icon variants" className="o-ui-sb-gallery-item-variant-section">
{variants.map(x => (
<Item key={x.name}>
<Header>{x.name}</Header>
Expand Down
2 changes: 1 addition & 1 deletion storybook/styles/docs.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@
}

.sbdocs.sbdocs-h2,
.sbdocs.sbdocs-h2:first-of-type {
.sbdocs > h2:first-of-type {
margin: 1.5rem 0;
font-size: var(--o-ui-fs-7);
}
Expand Down