Invalidate display link instead of pausing it when invalidating the nodes manager #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odes manager Pausing the display link on invalidation will still make it call the onAnimationFrame selector one more time as its already schedule. When this happens animation blocks will be called and crash while accessing the jsi runtime thats already dealloced.
fluiddot
approved these changes
Jun 1, 2022
There was a problem hiding this comment.
LGTM 🎊 !
Unfortunately, I can't manage to reproduce the original crash that this fix aims to address (i.e. EXC_BAD_ACCESS on rt.global()). However, since the fix comes from the original repository, I think it's safe to merge it 👍 .
NOTE: I've bumped the package version and generated a new tarball.
UPDATE: I tested the changes using this PR and manually setting the source of the Reanimated Podspec to point to this branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings the changes from software-mansion#3090 to prevent a crash when closing the editor.