Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Gutenberg reference to bring in the changes in this companion PR: WordPress/gutenberg#15532.
This PR adds a check to ensure
attributes.url
exists before attempting to callindexof
. Currently, there are scenarios which can result inattributes.id
being truthy, whileattributes.url
is null or undefined for an image block.When an image is cancelled before it is finished uploading, the
url
is set tonull
, but theid
of the block remains. The next time the post is edited, the local draft will contain the state which triggers the crash.Testing steps:
This was tested using the steps here: wordpress-mobile/WordPress-Android#9768 (comment)
Types of changes
This is a bug fix for the crash discovered here: wordpress-mobile/WordPress-Android#9768