Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caret position after inline paste. #869

Merged
merged 2 commits into from
Apr 17, 2019

Conversation

mkevins
Copy link
Contributor

@mkevins mkevins commented Apr 13, 2019

Description

This PR fixes part of this issue: #828 , specifically, when inline content is pasted. The corresponding Gutenberg PR is here: WordPress/gutenberg#14957 ; this PR modifies the gutenberg reference, with no other changes.

How has this been tested?

This has been tested using the steps here:
#828 (comment)

Screenshots

Types of changes

This is a bug fix, but currently only resolves a part of the original issue. It serves as an incremental improvement.

@mkevins mkevins added this to the v1.3 milestone Apr 13, 2019
@mkevins mkevins requested a review from daniloercoli April 16, 2019 02:15
Copy link
Contributor

@daniloercoli daniloercoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once GB hash conflicts are resolved.

@mkevins mkevins merged commit c58f0ab into develop Apr 17, 2019
@mkevins mkevins deleted the fix/caret-position-after-inline-paste branch April 17, 2019 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants