-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Gallery Block V1 and other experimental flags #6973
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Gallery block appears to function as expected. 👍🏻
I noted oddities on both iOS and Android that appear unrelated to these changes. Do you encounter these as well?
When appending an image to a Gallery block, it will also show an If uploading to a gallery all files need to be image formats
error toast. If the appended image already exists in the Gallery, the image will not be added. However, using the block inserter while focused upon a Gallery item, the image is added successfully. At times, the order of Gallery items is also unexpectedly shuffled.
This appears to be occurring as far back as release 24.6.
Screen recording
RPReplay_Final1720554628.MP4
Steps to Reproduce:
- Insert a Gallery block.
- Select media for the block.
- Move block selection to the Gallery block.
- Tap the inline appender.
- Add media already within the Gallery block.
- Note the error message and lack of new image.
- Move block selection to an Image block within the Gallery block.
- Tap the block inserter in the toolbar.
- Add media already within the Gallery block.
- Note the image is added.
- Move block selection to the Gallery block.
- Tap the inline appender.
- Add media already within the Gallery block.
- Note the error message, the lack of new image, and the existing images order is reshuffled.
I did notice that one, I forgot to mention it in the PR 😅 I was planning to work on that next.
Oh wow, this I did not notice, it seems a bit broken 🥲 I'll take a look so we can ship a fix for at least some of the issues. Thanks for the review and testing! |
I'm working on the issues above in WordPress/gutenberg#63426 I'll merge this PR and open a new one for the other fix. |
Related PRs:
To test:
PR submission checklist: